Fix verifyPlugin Gradle task
#919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary releases can be used again now that the latest builds of 241 (2024.1.4) and 242 (EAP) include updates to the Plugin DevKit plugin that can download sources for binary releases. (Binary releases mean the referenced IDE is extracted and run from the same binaries as consumer releases). This fixes verifyPlugin, which didn't support binary releases being disabled.
Without this, running tests could take up to 1 minute, mostly spent configuring Gradle. It appears that the extractor transformer would extract the IDE on each run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
verifyPluginGradle task after migrating to v2 of the Gradle IntelliJ Plugin. It was broken due to disabling theuseBinaryReleasesbuild feature, which controls whether the referenced IDE is downloaded as a consumer binary release from the main CDN, or from Maven. The default is to use consumer binary releases, but the Plugin DevKit plugin wasn't able to download sources for these references during debugging, etc. The Plugin DevKit has now been updated, and supports downloading sources for binary releases in 2024.1.4 and the latest 242 EAP.This PR also enables Gradle caching. Without this, Gradle appears to re-run the "extractor transformer" on each run, which seems to extract the IDE ready to be referenced. This means running tests can have additional overhead, up to 1 minute. Enabling caching removes this delay.